-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Gsplat fixedframe transform #12926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gsplat fixedframe transform #12926
Conversation
…et has an identity root transform and children have their world transform
|
Thank you for the pull request, @keyboardspecialist! ✅ We can confirm we have a CLA on file for you. |
|
|
The issue should contain a test data set. The However, here's a test data set that probably demonstrates what the issue was probably about: With the transform in the root tile, it looks fine. With the transform in the child tile, it looks wrong and wiggly The tilesets with a sandcastle: Cesium Splat Tileset Transform PR 12926.zip (It still uses the "old" extension format. I've prepared supporting the new extension format, but ... this was before the new extension format was ""final"", so it will have to be straightened out and reviewed...) |
|
Thanks @keyboardspecialist. Once those last comments are addressed this should be good to go. I confirmed that this fixes the tilesets that were having the precision issues. |
…s for all datasets

Description
Fixes issue with tilesets that have an identity root transform and child tiles with their own world transform. This uses the tileset bounding sphere center point transformed using
Transforms.eastNorthUpToFixedFrame.Previously, because of the identity, it led to tiles transforming themselves into world space prematurely leading to low quality output due to precision loss.
Issue number and link
#12925
Testing plan
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change